On Tue, 31 Mar 2026 18:51:02 GMT, Shiv Shah <[email protected]> wrote:
>> Convert 6 non-native aod tests from main/othervm to driver mode. Added
>> classpath to target process command in AODTestRunner.java since driver mode
>> doesn't inherit classpath like othervm.
>>
>> 4 native tests and 3 self-attach tests (-Djdk.attach.allowAttachSelf) stay
>> as othervm.
>>
>> Testing:
>> - Local macosx-aarch64: all 13 aod tests pass
>> - Mach5 linux-x64-debug, windows-x64-debug: all 13 pass
>
> Shiv Shah has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8338594: Remove standalone -XX:+UsePerfData from native tests and update
> copyrights
Changes requested by lmesnik (Reviewer).
test/hotspot/jtreg/vmTestbase/nsk/share/aod/AODTestRunner.java line 110:
> 108: // path to java
> 109: argParser.getTestedJDK() + File.separator + "bin" +
> File.separator + "java " +
> 110: (classPath != null ? "-classpath " +
> classPath + " " : "") +
better to fail in the line 106 if System.getProperty("test.class.path") is nt
set.
just say explicitly that
`System.getProperty("test.class.path")`
is required.
It might happen only if you run test outside of jtreg.
-------------
PR Review: https://git.openjdk.org/jdk/pull/30520#pullrequestreview-4039595265
PR Review Comment: https://git.openjdk.org/jdk/pull/30520#discussion_r3017879085
