On Wed, 2 Jul 2025 21:25:04 GMT, Calvin Cheung <cche...@openjdk.org> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @coleenp comments
>
> src/hotspot/share/classfile/moduleEntry.cpp line 52:
>
>> 50: ModuleEntry* ModuleEntryTable::_javabase_module = nullptr;
>> 51:
>> 52: oop ModuleEntry::module_oop() const { return _module_handle.resolve(); }
>
> (Pre-existing) Just wondering why this one-liner function doesn't reside in
> the moduleEntry.hpp?
I think it's because `OopHandle::resolve()` is an inline function, but we are
not allowed to include `xxx.inline.hpp` in non-inlined `.hpp` files.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26102#discussion_r2181036271
