On Wed, 2 Jul 2025 17:50:52 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @coleenp comments
>
> src/hotspot/share/runtime/reflection.cpp line 582:
>
>> 580: } else {
>> 581: oop module_oop = module_from->module_oop();
>> 582: precond(module_oop != nullptr);
>
> same here. "Module oop should be non-null in ModuleEntry"
We have just read the oop from the module entry and assert that it's not null,
so the original message didn't add any extra information. That's why I removed
it.
I have added back a message, "should have been initialized".
The real story is more complex, but I think this message willl give enough
hints -- the module oop is usually initialized inside the ModuleEntry
constructor, except for a few cases for the java.base module where the module
oop is retroactively updated. In any case, by the time we reach this assert,
the module oop must have been initialized in one of those possible paths.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26102#discussion_r2180678283
