On Mon, 9 Jun 2025 14:45:24 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> Well, now I am surprised :-). Thank you for looking that up, I've probably >> misunderstood the style and applied my own advice incorrectly. Sorry about >> the conflicting review comments. > > This typedef didn't really bother me because it's a local internal class. > The coding style might be that it has to declared with camel case though. This is C++, not C. There's no good reason to use a typedef of an anonymous struct. And yes to the underscores on even public members of PODs. There are lots of violations of both of those, but that's the current style after various discussions. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24847#discussion_r2135990161
