On Mon, 9 Jun 2025 14:32:52 GMT, Johan Sjölen <jsjo...@openjdk.org> wrote:
>> From https://wiki.openjdk.org/display/HotSpot/StyleGuide : >>> [#Names](https://wiki.openjdk.org/display/HotSpot/StyleGuide#StyleGuide-Names) >>> Instance variable names start with underscore "_", classes start with >>> upper case letter, local functions are all lower case, all must have >>> meaningful names. >> >> No mention of distinction based on public/private > > Well, now I am surprised :-). Thank you for looking that up, I've probably > misunderstood the style and applied my own advice incorrectly. Sorry about > the conflicting review comments. This typedef didn't really bother me because it's a local internal class. The coding style might be that it has to declared with camel case though. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24847#discussion_r2135862604
