On Mon, 9 Jun 2025 13:41:01 GMT, Radim Vansa <rva...@openjdk.org> wrote:
>> src/hotspot/share/oops/fieldInfo.cpp line 132:
>>
>>> 130: // We use both name and signature during the comparison; while JLS
>>> require unique
>>> 131: // names for fields, JVMS requires only unique name + signature
>>> combination.
>>> 132: typedef struct {
>>
>> Style: Use C++ struct def (no typedef), don't use trailing _t in the name
>> and write it as FieldPos. The fields are public, so no underscore as name
>> prefix for them.
>
> Now I am confused; @iklam just requested to use the underscores.
>From https://wiki.openjdk.org/display/HotSpot/StyleGuide :
> [#Names](https://wiki.openjdk.org/display/HotSpot/StyleGuide#StyleGuide-Names)
> Instance variable names start with underscore "_", classes start with upper
> case letter, local functions are all lower case, all must have meaningful
> names.
No mention of distinction based on public/private
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24847#discussion_r2135769155
