On Tue, 3 Jun 2025 00:51:04 GMT, David Holmes <dhol...@openjdk.org> wrote:

>> Matthias Baesken has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   TestBreakSignalThreadDump has issues with asan
>
> Changes look fine but I agree with Chris that we need to document why these 
> tests don't work with ASAN, though I think I'd prefer to see an `@comment` 
> before the `@requires !vm.asan` in the actual test files - assuming the 
> reason can be stated clearly and succinctly.

> > I like @dholmes-ora idea of adding an @comment.
> 
> Why not, I am fine with this ! Do you think the current comment suggestions 
> are okay ?

If you are talking about the 1-line reasons given in the comment above, I'm 
fine with that.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25575#issuecomment-2950805942

Reply via email to