On Mon, 2 Jun 2025 08:07:38 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
>> There are a couple of jtreg tests, especially in the HS area, with very >> special assumptions about memory layout/sizes . >> Those fail when the address sanitizer is configured ( --enable-asan ). >> The change adds a way to tag those tests with 'requires' so that they can be >> avoided easily when running jtreg tests with ASAN enabled. >> Adjusting the tests for "pleasing" the sanitizer is not always desired (if >> possible for some tests it can be done later) . >> While at it, also same is also added for ubsan . > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > TestBreakSignalThreadDump has issues with asan Changes look fine but I agree with Chris that we need to document why these tests don't work with ASAN, though I think I'd prefer to see an `@comment` before the `@requires !vm.asan` in the actual test files - assuming the reason can be stated clearly and succinctly. ------------- PR Review: https://git.openjdk.org/jdk/pull/25575#pullrequestreview-2890276148
