On Tue, 3 Jun 2025 12:30:18 GMT, Markus Grönlund <mgron...@openjdk.org> wrote:
>> src/hotspot/share/jfr/periodic/sampling/jfrCPUTimeThreadSampler.cpp line 235:
>>
>>> 233:
>>> 234: void JfrCPUTimeThreadSampler::on_javathread_create(JavaThread* thread)
>>> {
>>> 235: if (thread->is_Compiler_thread()) {
>>
>> is_hidden_from_external_view() + is_JfrRecorderThread() instead?
>
> tl->is_excluded() is volatile and can change during runtime, so it's better
> to add a timer unconditionally there.
why not just `is_excluded`?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25302#discussion_r2123673323
