On Tue, 3 Jun 2025 12:12:53 GMT, Johannes Bechberger <jbechber...@openjdk.org> wrote:
>> This is the code for the [JEP 509: CPU Time based profiling for >> JFR](https://openjdk.org/jeps/509). >> >> Currently tested using [this test >> suite](https://github.com/parttimenerd/basic-profiler-tests). This runs >> profiles the [Renaissance](https://renaissance.dev/) benchmark with >> - ... different heap sizes >> - ... different GCs >> - ... different samplers (the standard JFR and the new CPU Time Sampler and >> both) >> - ... different JFR recording durations >> - ... different chunk-sizes > > Johannes Bechberger has updated the pull request incrementally with two > additional commits since the last revision: > > - Fix include order > - Tiny refactoring src/hotspot/share/jfr/periodic/sampling/jfrCPUTimeThreadSampler.cpp line 235: > 233: > 234: void JfrCPUTimeThreadSampler::on_javathread_create(JavaThread* thread) { > 235: if (thread->is_Compiler_thread()) { is_hidden_from_external_view() + is_JfrRecorderThread() instead? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25302#discussion_r2123668189