On Sun, 25 May 2025 06:00:07 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> src/hotspot/share/classfile/javaClasses.cpp line 5519:
>>
>>> 5517: oop
>>> java_util_concurrent_locks_AbstractOwnableSynchronizer::get_owner_threadObj(oop
>>> obj) {
>>> 5518: assert(_owner_offset != 0, "Must be initialized");
>>> 5519: return obj->obj_field_acquire(_owner_offset);
>>
>> Is this a preexisting bug? If yes we should have this fixed in a separate
>> patch so it is eligible for backporting, etc.
>
> This is the dependent PR, there are no changes to src/hotspot in this PR.
> Maybe I should left this PR in draft until pull/25425 is integrated to avoid
> any confusion.
>
> In any case, it is changed to use obj_field_acquire because the field is
> volatile and accessed (asynchronously) from the thread handshake. So
> different to the access from VM_ThreadDump which is a VM operation.
Okay, I see the issue. The base branch is pull/25425 and the Skara is supposed
to retarget once that branch is integrated. It seems to have gone back to
master. I've fixed it now so the Files Changed no longer lists the files in
the other PR. Sorry for the confusing. I was initially wondering why there were
comments about files that are not in this PR.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25429#discussion_r2106100555
