On Tue, 13 May 2025 04:01:13 GMT, Chris Plummer <[email protected]> wrote:
>> What this PR is fixing is the issue with all of our nsk/jdi testing being
>> done with includevirtualthreads=y even though debuggers typically use the
>> default includevirtualthreads=n. As a result we have a testing gap with
>> includevirtualthreads=n.
>>
>> includevirtualthreads=y forces the debug agent to track all virtual threads
>> so they are returned by vm.allThreads(). Some tests need this since they use
>> vm.allThreads() to find the debuggee threads. Without
>> includevirtualthreads=y, vm.allThreads() usually won't return any virtual
>> threads (although it might return some for which events have been triggered).
>>
>> There are nearly 1200 nsk/jdi tests. There were about 350 tests that
>> actually needed includevirtualthreads=y, but most of these have been
>> addressed by other PRs, leaving the 20 or so tests being addressed in this
>> PR. With this PR now defaulting to includevirtualthreads=n, the tests that
>> require includevirtualthreads=y need to override the default by specifying
>> the -includevirtualthreads @run option.
>
> Chris Plummer has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update the set of tests that need to be run with -includevirtualthreads
test/hotspot/jtreg/vmTestbase/nsk/jdi/EventRequestManager/accessWatchpointRequests/accwtchpreq002.java
line 251:
> 249: String lineForComm = "lineForComm";
> 250:
> 251: //ThreadReference mainThread =
> debuggee.threadByNameOrThrow("main");
Q: Do you want to keep this commented out line?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24606#discussion_r2087600650