On Fri, 25 Apr 2025 02:26:11 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> Please review the change for following hotspot/jtreg/serviceability/sa/* >> tests to not check for JDK/VM shared libraries when running on static JDK. >> >> - test/hotspot/jtreg/serviceability/sa/ClhsdbPmap.java >> - test/hotspot/jtreg/serviceability/sa/sadebugd/PmapOnDebugdTest.java >> - test/hotspot/jtreg/serviceability/sa/sadebugd/RunCommandOnServerTest.java >> >> I tested the change on a `static-jdk` binary with a `static-jdk/bin/jhsdb` >> symlink to the `jhsdb` in a regular JDK binary. The tests pass with the >> change. Example test command: >> >> $ make test TEST="serviceability/sa/sadebugd/RunCommandOnServerTest.java" >> JDK_UNDER_TEST=/<snip>/JDK-8355439/build/linux-x86_64-server-fastdebug/images/static-jdk >> >> JDK_FOR_COMPILE=/<snip>/JDK-8355439/build/linux-x86_64-server-fastdebug/images/jdk > > This looks good. @sspitsyn @plummercj Thanks for your reviews! ------------- PR Comment: https://git.openjdk.org/jdk/pull/24836#issuecomment-2830977002
