On Wed, 23 Apr 2025 22:40:16 GMT, Jiangli Zhou <jian...@openjdk.org> wrote:
> Please review the change for following hotspot/jtreg/serviceability/sa/* > tests to not check for JDK/VM shared libraries when running on static JDK. > > - test/hotspot/jtreg/serviceability/sa/ClhsdbPmap.java > - test/hotspot/jtreg/serviceability/sa/sadebugd/PmapOnDebugdTest.java > - test/hotspot/jtreg/serviceability/sa/sadebugd/RunCommandOnServerTest.java > > I tested the change on a `static-jdk` binary with a `static-jdk/bin/jhsdb` > symlink to the `jhsdb` in a regular JDK binary. The tests pass with the > change. Example test command: > > $ make test TEST="serviceability/sa/sadebugd/RunCommandOnServerTest.java" > JDK_UNDER_TEST=/<snip>/JDK-8355439/build/linux-x86_64-server-fastdebug/images/static-jdk > > JDK_FOR_COMPILE=/<snip>/JDK-8355439/build/linux-x86_64-server-fastdebug/images/jdk This looks good. ------------- Marked as reviewed by sspitsyn (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/24836#pullrequestreview-2792866425
