On Mon, 20 Jan 2025 21:25:51 GMT, Simon Tooke <sto...@openjdk.org> wrote:
> This fix widens the regex used to determine if a JAVAHEAP line is correct in > the output of System.map/System.dump_map. Looks good 8-) Hi, >From our logs - existing passes on macos aarch64 include a line which matches, >e.g.: 0x0007c8000000-0x0007d0000000 134217728 rw-/rwx pvt 0 JAVAHEAP The failures where we don't match, they have p/a rather than pvt: 0x00030e900000-0x00030ec00000 3145728 rw-/rwx p/a 0 JAVAHEAP There are also the "cow" lines, I see in the JAVAHEAP classes.jsa line. I think we don't specifically need "cow" in the macprivate_or_shared definition - as long as we match the JAVAHEAP line with p/a we will pass. It's only classes.jsa marked a copy on write (makes sense), and there should always be another JAVAHEAP line for us to match. Presuming "private aliased" is a variation of private, so adding p/a variant is a trivial change for the test. ------------- Marked as reviewed by kevinw (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/23205#pullrequestreview-2564777308 PR Comment: https://git.openjdk.org/jdk/pull/23205#issuecomment-2604319139
