On Wed, 8 Jan 2025 21:01:37 GMT, Simon Tooke <sto...@openjdk.org> wrote:

>> This test fixes an issue with incomplete Windows threads not yet having a 
>> stack.  A test for a null stack_base is added to guard against the potential 
>> null dereference.  An additional test using ZGC is added to the jtreg 
>> SystemMapTest.
>
> Simon Tooke has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   test SystemMap with and without ZGC

Marked as reviewed by dholmes (Reviewer).

test/hotspot/jtreg/serviceability/dcmd/vm/SystemMapTest.java line 39:

> 37:  *          java.management
> 38:  *          jdk.internal.jvmstat/sun.jvmstat.monitor
> 39:  * @run testng/othervm -XX:+UsePerfData -XX:-UseZGC SystemMapTest

Technically you don't need to disable ZGC as the requires clause means it is 
already not the selected GC

-------------

PR Review: https://git.openjdk.org/jdk/pull/22870#pullrequestreview-2538658134
PR Review Comment: https://git.openjdk.org/jdk/pull/22870#discussion_r1908108908

Reply via email to