On Mon, 23 Dec 2024 18:43:07 GMT, Simon Tooke <sto...@openjdk.org> wrote:
> This test fixes an issue with incomplete Windows threads not yet having a > stack. A test for a null stack_base is added to guard against the potential > null dereference. An additional test using ZGC is added to the jtreg > SystemMapTest. Changes requested by lmesnik (Reviewer). test/hotspot/jtreg/serviceability/dcmd/vm/SystemMapTest.java line 39: > 37: * java.management > 38: * jdk.internal.jvmstat/sun.jvmstat.monitor > 39: * @run testng/othervm -XX:+UsePerfData -XX:+UseZGC SystemMapTest No need to add separate testcase for ZGC. It is expected that hotspot tests are usually executed to ensure that all functionality works with any GC. If you want to add it to ensure that regression testcase is always executed even no ZGC is set then please 1) add `* @requires vm.gc.Z` So testcase is not executed if non-ZGC GC (Parallel/Serial etc) is set explicitly. 2) Add ` * @bug 8346717` 3) Add id like `* @test id=zgc` to make testcase name clearer. ------------- PR Review: https://git.openjdk.org/jdk/pull/22870#pullrequestreview-2522246825 PR Review Comment: https://git.openjdk.org/jdk/pull/22870#discussion_r1897011178
