On Fri, 20 Dec 2024 20:21:39 GMT, Robert Toyonaga <d...@openjdk.org> wrote:
>> src/hotspot/os/windows/os_windows.cpp line 3626: >> >>> 3624: os::print_memory_mappings((char*)start, bytes, &fs); >>> 3625: assert(false, "bad release: [" PTR_FORMAT "-" PTR_FORMAT "): >>> %s", p2i(start), p2i(end), err); >>> 3626: #endif >> >> @roberttoyonaga Thinking about this, I propose to just remove the >> os::print_memory_mappings call here. I added this way back when we had >> problems on Windows with removing "striped" NUMA mappings, but those issues >> have long been solved. We still have the assertion check, so we will notice >> if something goes wrong. > > Ok I've removed it now You can also remove the ifdef assert, since assert() only fires if ASSERT is defined ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22745#discussion_r1894655240
