On Thu, 19 Dec 2024 22:52:39 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:
>> Robert Toyonaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert to using NmtVirtualMemoryLocker. Use defaultStream. Add comment for
>> SharedDecoder_lock
>
> src/hotspot/share/nmt/virtualMemoryTracker.cpp line 341:
>
>> 339: assert(_reserved_regions != nullptr, "Sanity check");
>> 340: assert(!MemTracker::is_done_bootstrap() ||
>> NmtVirtualMemory_lock->owned_by_self() , "Should have acquired
>> NmtVirtualMemory_lock");
>> 341:
>
> This line is kind of long. And why the space before the comma? And there's
> a bunch of
> these, suggesting there should be a helper to package this up.
Good point. I've gotten rid of this in favor of the helper that Coleen
suggested below.
> src/hotspot/share/utilities/vmError.cpp line 652:
>
>> 650:
>> 651: BEGIN
>> 652: if (MemTracker::enabled() && NmtVirtualMemory_lock != nullptr &&
>> MemTracker::is_done_bootstrap() && NmtVirtualMemory_lock->owned_by_self()) {
>
> This line is rather long.
Ok I've broken it up now
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22745#discussion_r1894218609
PR Review Comment: https://git.openjdk.org/jdk/pull/22745#discussion_r1894218393
