On Thu, 19 Dec 2024 19:20:21 GMT, Alex Menkov <amen...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: added NotifyFramePop test case to check JVMTI_ERROR_DUPLICATE is
>> returned
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/MethodExitTest/libMethodExitTest.cpp
> line 470:
>
>> 468: LOG("NotifyFramePop at VirtualThreadUnmount event returned expected
>> JVMTI_ERROR_DUPLICATE\n");
>> 469: } else {
>> 470: LOG("Failed: expected JVMTI_ERROR_DUPLICATE from NotifyFramePop at
>> VirtualThreadUnmount event\n");
>
> Would be nice to log returned value, something like
>
>
> LOG("Failed: NotifyFramePop at VirtualThreadUnmount returned %s (%d)
> instead of expected JVMTI_ERROR_DUPLICATE\n",
> TranslateError(err), err);
Thanks. Updated now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22798#discussion_r1893319148
