On Thu, 19 Dec 2024 04:46:12 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> The JVMTI NotifyFramePop should return JVMTI_ERROR_DUPLICATE in a case the >> specified FramePop event was already requested. This makes it consistent >> with the SetBreakpoint which returns the JVMTI_ERROR_DUPLICATE on an attempt >> to add a breakpoint request that was already requested. >> >> CSR: [8346460](https://bugs.openjdk.org/browse/JDK-8346460): NotifyFramePop >> should return JVMTI_ERROR_DUPLICATE >> >> Testing: >> - tested with mach5 tiers 1-6 > > Serguei Spitsyn has updated the pull request incrementally with one > additional commit since the last revision: > > review: added NotifyFramePop test case to check JVMTI_ERROR_DUPLICATE is > returned test/hotspot/jtreg/serviceability/jvmti/vthread/MethodExitTest/libMethodExitTest.cpp line 470: > 468: LOG("NotifyFramePop at VirtualThreadUnmount event returned expected > JVMTI_ERROR_DUPLICATE\n"); > 469: } else { > 470: LOG("Failed: expected JVMTI_ERROR_DUPLICATE from NotifyFramePop at > VirtualThreadUnmount event\n"); Would be nice to log returned value, something like LOG("Failed: NotifyFramePop at VirtualThreadUnmount returned %s (%d) instead of expected JVMTI_ERROR_DUPLICATE\n", TranslateError(err), err); ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22798#discussion_r1893023250
