On Thu, 19 Dec 2024 12:52:34 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> Please review this change that makes AccessFlags and modifier_flags u2 types
>> and removes the last remnants of Hotspot adding internal access flags. This
>> change moves AccessFlags and modifier_flags in Klass to alignment gaps
>> saving 16 bytes. From pahole: so it's a bit better.
>>
>> before:
>>
>> /* size: 216, cachelines: 4, members: 25, static members: 17 */
>> /* sum members: 194, holes: 3, sum holes: 18 */
>>
>>
>> after:
>>
>> /* size: 200, cachelines: 4, members: 25, static members: 17 */
>> /* sum members: 188, holes: 4, sum holes: 12 */
>>
>>
>> We may eventually move the modifiers to java.lang.Class but that's WIP.
>>
>> Tested with tier1-7 on oracle platforms. Did test builds on other platforms
>> (please try these changes ppc/arm32 and s390). Also requires minor Graal
>> changes.
>
> Coleen Phillimore has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - Update src/hotspot/cpu/ppc/templateInterpreterGenerator_ppc.cpp
>
> Co-authored-by: David Holmes
> <62092539+dholmes-...@users.noreply.github.com>
> - Update src/hotspot/share/opto/library_call.cpp
>
> Co-authored-by: David Holmes
> <62092539+dholmes-...@users.noreply.github.com>
src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp line 823:
> 821: {
> 822: Label done;
> 823: __ load_unsigned_short(r0, access_flags);
Could you please use `ldrh` rather than `load_unsigned_short` here?
`load_unsigned_short` is only used in the termplate interpreter, and is a
hangover from the hand-translation from x86.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22246#discussion_r1892155007
