On Thu, 19 Dec 2024 01:48:49 GMT, David Holmes <[email protected]> wrote:
>> Coleen Phillimore has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Update src/hotspot/cpu/ppc/templateInterpreterGenerator_ppc.cpp >> >> Co-authored-by: David Holmes >> <[email protected]> >> - Update src/hotspot/share/opto/library_call.cpp >> >> Co-authored-by: David Holmes >> <[email protected]> > > src/hotspot/share/opto/library_call.cpp line 3874: > >> 3872: Node* LibraryCallKit::generate_interface_guard(Node* kls, RegionNode* >> region) { >> 3873: return generate_klass_flags_guard(kls, JVM_ACC_INTERFACE, 0, region, >> 3874: Klass::access_flags_offset(), >> TypeInt::CHAR, T_CHAR); > > Is this CHAR/T_CHAR because you want unsigned? Yes. T_SHORT generates the wrong code. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22246#discussion_r1891931433
