On Thu, 19 Dec 2024 00:09:38 GMT, Alex Menkov <amen...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: removed unneeded check for JvmtiExport::can_post_frame_pop() > > src/hotspot/share/prims/jvmtiEnvThreadState.cpp line 79: > >> 77: _pops->remove_at(idx); >> 78: } >> 79: assert(_pops->length() == 0, "sanity check"); > > Suggestion: > > _pops->clear(); Good suggestion, thanks. Fixed now. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22744#discussion_r1891155240
