On Tue, 17 Dec 2024 03:20:20 GMT, Chris Plummer <[email protected]> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> added extra check to post_method_exit_inner before clear_frame_pop to
>> avoid assert
>
> src/hotspot/share/interpreter/interpreterRuntime.cpp line 580:
>
>> 578: // notify debugger of an exception catch
>> 579: // (this is good for exceptions caught in native methods as well)
>> 580: if (JvmtiExport::can_post_on_exceptions() ||
>> JvmtiExport::can_post_frame_pop()) {
>
> This doesn't seem like it is related to ClearAllFramePops.
Yes, it does not relate to the `ClearAllFramePops` directly. But it is needed
for correctness of the `NotifyFramePop`. I do not feel it is worth to separate
this change.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22744#discussion_r1888946592
