On Thu, 19 Dec 2024 05:24:20 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> New JVMTI function `ClearAllFramePops` will help to speedup debugger single >> stepping in some cases. >> Additionally, the JVMTI `NotifyFramePop` implementation was fixed to return >> `JVMTI_ERROR_DUPLICATE` to make it consistent with the `SetBreakpoint` which >> also returns this error. >> >> The JDWP agent fix will be needed to make use of this new JVMTI function. >> The corresponding debugger bug is: >> [8229012](https://bugs.openjdk.org/browse/JDK-8229012): When single >> stepping, the debug agent can cause the thread to remain in interpreter mode >> after single stepping completes >> >> CSR: [8346144](https://bugs.openjdk.org/browse/JDK-8346144): add >> ClearAllFramePops function to speedup debugger single stepping in some cases >> >> Testing: >> - mach5 tiers 1-6 were run to make sure this fix caused no regressions >> - Chris tested the JVMTI patch with his JDWP fix of >> [8229012](https://bugs.openjdk.org/browse/JDK-8229012). > > Serguei Spitsyn has updated the pull request incrementally with one > additional commit since the last revision: > > review: addressed comments for new test, jvmti.xml, jvmtiEnvThreadState.cpp Marked as reviewed by amenkov (Reviewer). src/hotspot/share/prims/jvmtiEnvThreadState.hpp line 89: > 87: void set(JvmtiFramePop& fp); > 88: void clear(JvmtiFramePop& fp); > 89: void clear_all(); Need to update copyright year ------------- PR Review: https://git.openjdk.org/jdk/pull/22744#pullrequestreview-2515999210 PR Review Comment: https://git.openjdk.org/jdk/pull/22744#discussion_r1893027385
