On Fri, 13 Dec 2024 11:50:52 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> updated comment
>
> src/hotspot/share/services/attachListener.cpp line 670:
>
>> 668: // for v1 also name/arguments should not exceed
>> name_length_max/arg_length_max.
>> 669: if (strlen(name()) > AttachOperation::name_length_max) {
>> 670: log_error(attach)("Failed to read request: name is too long");
>
> Nit: I'd suggest to be more specific: "Failed to read request: attach
> operation name is too long"
There is "attach" in the log prefix, so I made it "Failed to read request:
operation name is too long"
And updated similar logging for arguments several lines below
> src/hotspot/share/services/attachListener.hpp line 238:
>
>> 236: virtual void complete(jint result, bufferedStream* result_stream) = 0;
>> 237:
>> 238: class ReplyWriter; //forward declaration
>
> Nit: The comment should start with a space.
Fixed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22223#discussion_r1884559859
PR Review Comment: https://git.openjdk.org/jdk/pull/22223#discussion_r1884560028
