On Wed, 11 Dec 2024 11:17:36 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> updated comment > > src/hotspot/os/posix/attachListener_posix.cpp line 145: > >> 143: private: >> 144: // the connection to the client >> 145: SocketChannel _socket; > > Nit: The name `_socket` is misleading. I'd suggest to rename it to > `_socket_channel`. Fixed > src/hotspot/share/services/attachListener.hpp line 251: > >> 249: // Attach client can make sanity connect/disconnect. >> 250: // In the case we get "premature EOF" error. >> 251: // If "may_be_empty" is true, the error is not logged. > > Nits or two minor suggestions: > - replace: "In the case" => "In that case" > - replace: "may_be_empty" => may_be_empty Fixed ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22223#discussion_r1881052345 PR Review Comment: https://git.openjdk.org/jdk/pull/22223#discussion_r1881052094
