On Tue, 10 Dec 2024 09:02:33 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> And they're not the same as access flags. > > The "recalculate" is what is throwing me - that suggests the flags were > already "calculated" somewhere. Does it really mean just "calculate" and that > we do it between parsing and adding to SD? (Not that I know what the > significance of that placement is meant to be.) So I did some old code reading. We used to create the mirror when creating InstanceKlass, then later in ClassFileParser, we recalculated the modifier flags after the inner class attributes are added to the InstanceKlass. Now we create the mirror after all of this. Adding to the SystemDictionary is the point where the class is published so they have to be correct for that, which is what that part of the comment meant. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22618#discussion_r1878089439
