On Fri, 22 Nov 2024 16:04:34 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Kevin Walls has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains eight additional
>> commits since the last revision:
>>
>> - Exeption handling feedback
>> - Merge remote-tracking branch 'upstream/master' into
>> 8344394_Management_rmi_post_sm
>> - Remove last import sun.reflect.misc.ReflectUtil
>> - imports
>> - unwrap, exception handling
>> - ReflectUtil removal
>> - tweak
>> - 8344394: Remove SecurityManager and related calls from java.management.rmi
>
> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java
> line 32:
>
>> 30: import java.rmi.UnmarshalException;
>> 31: import java.rmi.server.Unreferenced;
>> 32: import java.security.PrivilegedActionException;
>
> should this be removed too?
To be addressed in JDK-8345079
> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java
> line 1286:
>
>> 1284:
>> 1285: /** @throws UnsupportedOperationException {@inheritDoc} */
>> 1286: private Object doPrivilegedOperation(final int operation,
>
> Maybe rename "doPrivilegedOperation" into an overload of "doOperation"
To be addressed in JDK-8345079
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22270#discussion_r1862310359
PR Review Comment: https://git.openjdk.org/jdk/pull/22270#discussion_r1862310553
