On Mon, 18 Nov 2024 15:00:22 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Kevin Walls has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 16 additional >> commits since the last revision: >> >> - Exception handling >> - tidyup >> - Suppression tidyup >> - unnecessary variables >> - remove redundant method >> - Merge remote-tracking branch 'upstream/master' into >> java_management_post_sm >> - ReflectUtil removals >> - Remove checkPackageAccess calls >> - Remove Util.check... calls >> - mostly removing imports >> - ... and 6 more: https://git.openjdk.org/jdk/compare/2b351ce8...9628234f > > src/java.management/share/classes/javax/management/remote/JMXConnectorFactory.java > line 448: > >> 446: { return super.loadClass(name, >> resolve); } >> 447: } >> 448: : null; > > I suspect we could just return `parent` here but that might require some > deeper investigation. Agreed, not sure if this is really needed. It has only one usage. Have left as is for now... ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22100#discussion_r1858285043
