On Mon, 18 Nov 2024 17:08:21 GMT, Kevin Walls <kev...@openjdk.org> wrote:
>> Remove redundant SecurityManager, AccessController references
>> (following on from JDK-8338411: Implement JEP 486: Permanently Disable the
>> Security Manager).
>
> Kevin Walls has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add back checkClassLoader
src/java.management/share/classes/sun/management/ManagementFactoryHelper.java
line 194:
> 192: if (logging.isPresent()) {
> 193: return Class.forName(logging.get(), className);
> 194: } else {
Suggestion:
} else {
src/java.management/share/classes/sun/management/VMManagementImpl.java line 249:
> 247:
> 248: // construct PerfInstrumentation object
> 249: Perf perf = Perf.getPerf();
Suggestion:
Perf perf = Perf.getPerf();
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22100#discussion_r1848511628
PR Review Comment: https://git.openjdk.org/jdk/pull/22100#discussion_r1848512131
