On Wed, 20 Nov 2024 14:57:12 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Kevin Walls has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - newline
>> - remove implSetParallelism from VSThreadSchedulers
>
> src/jdk.management/share/classes/com/sun/management/internal/VirtualThreadSchedulerImpls.java
> line 62:
>
>> 60: @Override
>> 61: public final void setParallelism(int size) {
>> 62: Util.checkControlAccess();
>
> Dropping this means that we don't need setParallelism in the base class no
> need for implSetParallelism. In its place we just rename implSetParallelism
> to setParallelism in the subclasses.
Got it, yes can remove implSetParallelism.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22155#discussion_r1851754072
