On Fri, 25 Oct 2024 23:20:02 GMT, Alexander Zuev <kiz...@openjdk.org> wrote:
>> Right the JBS is about SM & SecurityException, but the test was repurposed >> to check if InvalidMidiDataException is thrown and to test this case for >> code coverage (when it was initially reviewed). >> I can update the test summary accordingly - >> **"Check if MidiSystem.getSoundbank() throws InvalidMidiDataException when >> provided with invalid soundbank data"** >> >> @azuev-java Your thoughts? > > That and possibly rename the test because now it does not have anything to do > with the SecurityException. Now we only check that providing an empty file > causes the InvalidMidiDataException so EmptySoundBankTest or something to > that extent would be a better name. Fixed in https://github.com/openjdk/jdk/pull/21498/commits/934e1c28f783b32c43e6977f0e1ba6e1c68f810f ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1819186623
