On Fri, 25 Oct 2024 20:48:14 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> src/java.base/share/classes/java/security/AccessControlContext.java line 32:
>>
>>> 30:
>>> 31: /**
>>> 32: * AccessControlContext was used with a SecurityManager for access
>>> control decisions
>>
>> I'm not sure how you use this name elsewhere. To me, one either uses
>> "Security Manager" as the name for the technique or `SecurityManager`
>> (inside `{@code}`) as the name for the class.
>
> Right, it should be "the Security Manager", but we can also link to the
> `SecurityManager` class as plain text. I'll make some wording changes to
> this class and `AccessController`.
Fixed in
https://github.com/openjdk/jdk/pull/21498/commits/275dabd4dbc8f443901dc5d82b281111dcbf15e6
>> src/java.base/share/classes/java/security/Policy.java line 374:
>>
>>> 372: *
>>> 373: * @param codesource the CodeSource to which the returned
>>> 374: * PermissionCollection has been granted
>>
>> Can we say this parameter is ignored? I see some other methods said so.
>>
>> Same with the other `getPermissions` and `implies`.
>
> Yes, good suggestion.
Fixed in
https://github.com/openjdk/jdk/pull/21498/commits/4981da0fe50919e60cc036371f8bc8d7ee153849
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1819165566
PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1819166630
