On Thu, 24 Oct 2024 15:57:25 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Sean Mullan has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 150 commits: >> >> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411 >> - Merge >> - Update @summary to replace "if the right permission is granted" can be >> replaced with "package java.lang is open to unnamed module". >> - Remove println about Security Manager. >> - Remove unused static variable NEW_PROXY_IN_PKG. >> - Remove static variable `DEFAULT_POLICY` and unused imports. >> - Remove hasSM() method and code that calls it, and remove comment about >> running test manually with SM. >> - clientlibs: import order >> - warning-string >> - java/net/httpclient/websocket/security/WSURLPermissionTest.java: >> integrated review feedback in renamed WSSanityTest.java >> - ... and 140 more: https://git.openjdk.org/jdk/compare/f7a61fce...cb50dfde > > src/java.desktop/share/classes/java/beans/PropertyEditorManager.java line 71: > >> 69: * >> 70: * @param targetType the class object of the type to be edited >> 71: * @param editorClass the class object of the editor classs > > Suggestion: > > * @param editorClass the class object of the editor class > > Typo with an extra ‘s’. The line should remain unchanged. Fixed in https://github.com/openjdk/jdk/pull/21498/commits/b78a7b6a2e5f96a98c81c68a8d9db3745e4efc3b > src/java.desktop/share/classes/javax/swing/WindowConstants.java line 1: > >> 1: /* > > Needs updating the copyright year. Fixed in https://github.com/openjdk/jdk/pull/21498/commits/b78a7b6a2e5f96a98c81c68a8d9db3745e4efc3b ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1819200392 PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1819172129
