On Thu, 24 Oct 2024 15:04:08 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Sean Mullan has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 150 commits: >> >> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411 >> - Merge >> - Update @summary to replace "if the right permission is granted" can be >> replaced with "package java.lang is open to unnamed module". >> - Remove println about Security Manager. >> - Remove unused static variable NEW_PROXY_IN_PKG. >> - Remove static variable `DEFAULT_POLICY` and unused imports. >> - Remove hasSM() method and code that calls it, and remove comment about >> running test manually with SM. >> - clientlibs: import order >> - warning-string >> - java/net/httpclient/websocket/security/WSURLPermissionTest.java: >> integrated review feedback in renamed WSSanityTest.java >> - ... and 140 more: https://git.openjdk.org/jdk/compare/f7a61fce...cb50dfde > > src/java.desktop/share/classes/java/awt/Font.java line 1780: > >> 1778: * <p> >> 1779: * The property value should be one of the forms accepted by >> 1780: * {@code Font.decode(String)} > > Suggestion: > > * {@code Font.decode(String)}. > > Period is missing. Not part of this change, can be fixed later as a follow-on cleanup. > src/java.desktop/share/classes/java/beans/Expression.java line 1: > >> 1: /* > > Needs copyright year update. Fixed in https://github.com/openjdk/jdk/pull/21498/commits/a7a4944630d63874a8d360cec798247eab144b42 > test/jdk/java/awt/regtesthelpers/process/ProcessCommunicator.java line 1: > >> 1: /* > > Copyright year needs updating. Fixed in https://github.com/openjdk/jdk/pull/21498/commits/a7a4944630d63874a8d360cec798247eab144b42 > test/jdk/java/beans/XMLEncoder/6777487/TestCheckedCollection.java line 1: > >> 1: /* > > Copyright years need updating. Fixed in https://github.com/openjdk/jdk/pull/21498/commits/a7a4944630d63874a8d360cec798247eab144b42 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1819152998 PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1819155061 PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1819156309 PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1819156796
