On Thu, 31 Oct 2024 02:23:24 GMT, Ioi Lam <ik...@openjdk.org> wrote: >> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://openjdk.org/jeps/483). >> >> ---- >> Note: this is a combined PR of the following individual PRs >> - https://github.com/openjdk/jdk/pull/20516 >> - https://github.com/openjdk/jdk/pull/20517 >> - https://github.com/openjdk/jdk/pull/20843 >> - https://github.com/openjdk/jdk/pull/20958 >> - https://github.com/openjdk/jdk/pull/20959 >> - https://github.com/openjdk/jdk/pull/21049 >> - https://github.com/openjdk/jdk/pull/21143 > > Ioi Lam has updated the pull request incrementally with one additional commit > since the last revision: > > Fixed whitespace; fixed minimal build
src/hotspot/share/cds/aotClassInitializer.cpp line 348: > 346: } > 347: JavaValue result(T_VOID); > 348: JavaCalls::call_static(&result, ik, Based on the discussions in JDK-8342283, do we need a memory fence after the call to runtimeSetup? I think we do to be consistent with the non-AOTCache run as there is a fence after `<clinit>` (when this code would normally run) due to the initialization lock. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21642#discussion_r1825400292
