On Tue, 22 Oct 2024 10:12:10 GMT, Kevin Walls <kev...@openjdk.org> wrote:
>> Alex Menkov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - updated comment
>> - feedback
>
> test/hotspot/jtreg/serviceability/attach/AttachAPIv2/CompatTest.java line 48:
>
>> 46: public static void main(String[] args) throws Exception {
>> 47: // if the test (client part) in the "compat" mode
>> 48: boolean clientCompat =
>> "true".equals(System.getProperty("jdk.attach.compat"));
>
> Boolean.getBoolean("jdk.attach.compat") ignores case for us as well.
> But more generally, are we happy with "jdk.attach.compat" as a boolean flag,
> or would "jdk.attach.version" be better?
> (which is mainly asking if we think there might ever be another version!)
I thought about making the property numeric, but that adds complexity in the
logic and I don't think we will need another version soon. Anyway it's
internal property for testing only, so we can change it any time.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20782#discussion_r1811198803
