On Tue, 15 Oct 2024 00:21:41 GMT, Alex Menkov <amen...@openjdk.org> wrote:
>> The fix improves Attch API protocol and implements updated protocol on >> windows; shared code is ready to implement updated protocol support on other >> platforms. >> More detailed explanations on the 1st comment. >> >> Testing: tier1,tier2,tier3,tier4,hs-tier5-svc >> manually tested backward compatibility (old tools can attach to current >> VMs, current tools can attach to older VMs) on Windows with jdk21u and jdk8u. > > Alex Menkov has updated the pull request incrementally with one additional > commit since the last revision: > > renamed JVM_EnqueueOperation2 > > renamed JVM_EnqueueOperation2 to JVM_EnqueueOperation_v2 for consistency > (per Serguei request) src/hotspot/os/windows/attachListener_windows.cpp line 40: > 38: // executes a small stub generated by the client. The stub invokes the > 39: // JVM_EnqueueOperation or JVM_EnqueueOperation_v2 function which checks > the operation parameters > 40: // and enqueues the operation request to the queue serviced by the attach > listener. The thread created by Nit: Just a suggestion to simplify this line of comment a little bit: // and enqueues the operation request for the attach listener. The thread created by ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20782#discussion_r1800830693
