On Tue, 22 Oct 2024 15:50:15 GMT, Andrew Haley <a...@openjdk.org> wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with six
>> additional commits since the last revision:
>>
>> - Fix comments in objectMonitor.hpp
>> - Move frame::saved_thread_address() to platform dependent files
>> - Fix typo in jvmtiExport.cpp
>> - remove usage of frame::metadata_words in possibly_adjust_frame()
>> - Fix comments in c2 locking paths
>> - Revert and simplify changes to c1_Runtime1 on aarch64 and riscv
>
> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 5357:
>
>> 5355:
>> 5356: void MacroAssembler::dec_held_monitor_count() {
>> 5357: Address dst = Address(rthread,
>> JavaThread::held_monitor_count_offset());
>
> Suggestion:
>
> // Clobbers: rscratch1 and rscratch2
> void MacroAssembler::dec_held_monitor_count() {
> Address dst = Address(rthread, JavaThread::held_monitor_count_offset());
Added.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1813515113
