On Wed, 9 Oct 2024 14:50:30 GMT, Ramkumar Sunderbabu <rsunderb...@openjdk.org>
wrote:
> The System property "docker.support" defined in VMProps gives a wrong
> impression that it is tied to docker alone. The property is common for any
> container runtime. Hence, it needs to be renamed as "container.support".
>
> Positive Testing:
> tier1,tier2,tier3 - to check stability
> tier5 - to run container tests
>
> Negative Testing:
> Ran the following groups in hosts where container is not present.
> open/test/hotspot/jtreg/containers/
> open/test/jdk/jdk/internal/platform/docker/
> open/test/jdk/jdk/internal/platform/cgroup/
Seems OK to me. One minor nit.
test/lib/jdk/test/lib/Container.java line 27:
> 25:
> 26: public class Container {
> 27: // Use this property to specify container location on your system.
Suggestion:
// Use this property to specify container runtime location (e.g. docker) on
your system.
-------------
PR Review: https://git.openjdk.org/jdk/pull/21423#pullrequestreview-2358152114
PR Review Comment: https://git.openjdk.org/jdk/pull/21423#discussion_r1794127601
