On Tue, 17 Sep 2024 08:44:41 GMT, Kevin Walls <kev...@openjdk.org> wrote:
>> The few uses of the operation parameter type "JULONG" in Diagnostic Commands >> should be changed to INT. > > Kevin Walls has updated the pull request incrementally with one additional > commit since the last revision: > > Additional typos/default values Thanks Sonia - Happy to tweak other help items as part of this. DCmdQuery is not enabled in any build except through a source change, but yes that width is clearly an INT. DCmdView has the same width param, but states it has no default, when the default is actually 100. Fixing these, and one other typo in an example. Yes, ArgumentParser I thought best to leave alone for now, callers handle it how they need. The other INTEGERs yes can standardise those in: src/jdk.jfr/share/classes/jdk/jfr/internal/dcmd/DCmdDump.java src/jdk.jfr/share/classes/jdk/jfr/internal/dcmd/DCmdStart.java Thanks! ------------- PR Comment: https://git.openjdk.org/jdk/pull/21021#issuecomment-2354976215
