On Mon, 16 Sep 2024 15:39:58 GMT, Kevin Walls <kev...@openjdk.org> wrote:
> The few uses of the operation parameter type "JULONG" in Diagnostic Commands > should be changed to INT. Hi Kevin, I had some questions about this change. Regarding the `INTEGER` -> `INT` change, I was wondering if the plan was to also update that for the remaining JFR dcmds ([DcmdView.java](https://github.com/openjdk/jdk/blob/master/src/jdk.jfr/share/classes/jdk/jfr/internal/dcmd/DCmdView.java#L111), [DcmdDump.java](https://github.com/openjdk/jdk/blob/master/src/jdk.jfr/share/classes/jdk/jfr/internal/dcmd/DCmdDump.java#L239), etc) and whether those changes should go in together? Also, I noticed the `getOptions` text is wrong for `width` in [DcmdQuery.java](https://github.com/openjdk/jdk/blob/master/src/jdk.jfr/share/classes/jdk/jfr/internal/dcmd/DCmdQuery.java#L157). width (Optional) Maximum number of horizontal characters. (BOOLEAN, false) Perhaps you can also fix this with this PR. Lastly, for `ArgumentParser.java`, I was thinking you could change `parseLong` to `parseInt`. However, I noticed that in [QueryRecording.java](https://github.com/openjdk/jdk/blob/master/src/jdk.jfr/share/classes/jdk/jfr/internal/dcmd/QueryRecording.java#L67), I see `width` and `cell-height` are downgraded to ints, whereas `maxAge` is used as a Long. So perhaps it should stay that way and it's something to note for anyone else looking at the PR :-) Thanks! ------------- PR Comment: https://git.openjdk.org/jdk/pull/21021#issuecomment-2353910457
