On Tue, 10 Sep 2024 13:06:25 GMT, Kevin Walls <kev...@openjdk.org> wrote:

>> Remove very very old serialization compatibility logic from JMX.
>> 
>> This relates to keeping the JDK's JMX implementation compatible with JMX 
>> versions from when JMX was a separate component, before being integrated 
>> into JDK 5.  It should all be removed.
>
> Kevin Walls has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Remove a list level in Javadoc.

Changes requested by dfuchs (Reviewer).

src/java.management/share/classes/javax/management/modelmbean/ModelMBeanNotificationInfo.java
 line 104:

> 102: 
> 103:     private static final long serialVersionUID = -7445681389570207141L;
> 104:     private static final ObjectStreamField[] serialPersistentFields =

Same here:
Suggestion:

    /**
     * @serialField notificationDescriptor Descriptor The descriptor
     *   containing the appropriate metadata for this instance
     */
    private static final ObjectStreamField[] serialPersistentFields =

-------------

PR Review: https://git.openjdk.org/jdk/pull/20856#pullrequestreview-2292546453
PR Review Comment: https://git.openjdk.org/jdk/pull/20856#discussion_r1751983528

Reply via email to