On Thu, 5 Sep 2024 14:57:16 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Test > > Wow. I hadn't realized so many classes were impacted. I thought there was > just a few! > > Look good in general. It could be good to write a test that sets the property > with 1.0 and 1.1, and that verifies that something (e.g. an ObjectName?) > serialized with property=1.0 can be deserialized with property=1.1, and > conversely. > > That would validate that setting the property no longer has any effect. Thanks Daniel @dfuch , we can use a version of what we had before, there was a simple check on ObjectName fields. I added it, will fail in a JDK that respects jmx.serial.version. ------------- PR Comment: https://git.openjdk.org/jdk/pull/20856#issuecomment-2332225753
