On Fri, 30 Aug 2024 20:54:33 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
> When SA fails to open/attach to a core file on linux or OSX, include a note > about using LIBSAPROC_DEBUG=1 in the error message. No one remembers this > magic, so it is useful to provide here. Even I always have to resort to > looking up the symbol in the SA source since I can never remember it. The > extra output you get with LIBSAPROC_DEBUG=1 is often enough for the user to > determine the root cause, or at least help an SA engineer determine the cause. > > Test by running all SA tests and also tier1. > > Also did manual testing with forced errors reading core files to make sure > the error output is as expected. This pull request has now been integrated. Changeset: a22e932a Author: Chris Plummer <cjplum...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/a22e932ab838762a013fc25b8061165be93feeb3 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod 8337163: Improve SA error message when failing to attach to a core file Reviewed-by: amenkov, kevinw ------------- PR: https://git.openjdk.org/jdk/pull/20800
