On Thu, 8 Aug 2024 19:59:04 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
>> Chris Plummer has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Minor improvment to datadump output >> - Add test cast for new debug agent datadump support > > test/jdk/com/sun/jdi/DataDumpTest.java line 51: > >> 49: * @library /test/lib >> 50: * @modules jdk.jdi >> 51: * @build DataDumpTest > > Is the build needed to build 'DataDumpTestTarg' because it is not explicitly > used by the test? It's not needed because it is in the same file. I'm not even sure it would work. > test/jdk/com/sun/jdi/DataDumpTest.java line 52: > >> 50: * @modules jdk.jdi >> 51: * @build DataDumpTest >> 52: * @run main/othervm/timeout=15 DataDumpTest > > Is the othervm is really needed in this test? > Also, it is unclear why the timeout=15 and not usual 120? Both of these were to help me with debugging. The test was timing out, and I wanted it to timeout faster. I can undo the timeout=15. For othervm, I forget the details, other than output and failure messages seem to differ between othervm and driver, and for debugging I found othervm easier to work with. I can change it to driver. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20367#discussion_r1710287426 PR Review Comment: https://git.openjdk.org/jdk/pull/20367#discussion_r1710289564
