On Thu, 8 Aug 2024 02:23:39 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Thank you for your help. I already made it by adding `@build >> jdk.test.lib.Utils`. Do I need to try to add `@clean >> jdk.test.lib.util.JavaAgentBuilder` and test again? > > I am not too sure adding the `@build jdk.test.lib.Utils` is a good thing. > This test definition nor the test code uses/references that class. So it's > odd to be adding a build tag for an indirect dependent class (and only that > specific class). I felt the `@clean jdk.test.lib.util.JavaAgentBuilder` would > be a better option since that `jdk.test.lib.util.JavaAgentBuilder` class is > being used by the test definition. > > Having said that, it's just a personal opinion and I would let hotspot and > serviceability area members to decide what approach to use here. So I would > suggest you wait to hear from them before changing anymore. Building a test library class not actually used by the test is certainly somewhat odd. I wasn't aware of the `@clean` workaround but I see a lot of vmTestbase tests use it, so please try the `@clean` as Jai suggested. Thanks ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20373#discussion_r1708600374