On Mon, 5 Aug 2024 10:34:56 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Jiawei Tang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> change the format of the testcase file > > test/hotspot/jtreg/serviceability/jvmti/vthread/TestPinCaseWithCFLH/TestPinCaseWithCFLH.java > line 37: > >> 35: * @modules java.base/java.lang:+open >> 36: * @compile TestPinCaseWithCFLH.java >> 37: * @run driver jdk.test.lib.util.JavaAgentBuilder > > Hello @jia-wei-tang, does adding an additional `@build > jdk.test.lib.thread.VThreadPinner` line before the `@run` line help fix the > `NoClassDefFoundError` you note in your comment? Hello @jia-wei-tang, I see that a `@build jdk.test.lib.util.JavaAgentBuilder` was added in the latest update to the PR. Did that help solve the NoClassDefFoundError you were running into when running those tests? I find it surprising that this specific class is required in the `@build` declaration, since that class itself is part of the `@run` directive. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20373#discussion_r1704897105
